Final LP staking implementation

[devin]

Hi everyone - great discussion here. Responding to a few points that were brought up.

@william

With standard solutions, the staking contract is the one who will receive rewards (if any, due to the limitation mentioned in the article) for all users, but there would be no way to redistribute those to the users directly. In the Ampl model there is a rescueFundsFromStakingPool which only the owner can call to retrieve those extra rewards, but then the community would need to decide at the end what to do with those rewards and if those needs to be redistributed a new solution/contract may be needed (I did a check in the Geyser.sol of GYSR but don’t see a rescue method).

On the airdrop question, you are correct that there is no admin function in the current GYSR contract to withdraw arbitrary tokens. We have had discussions on the “right” way to handle those airdrops, and intend to support that case in the future.

@Salome

This could lead to a scenario where a user with large amounts of $GYSR can potentially take advantage of this mechanic and receive additional rewards in return. Since rewards are received from a shared pool, their gain would reduce the portion of rewards earned by other users. This kind of competitive environment for LPs is not ideal for the Idle ecosystem and the Pilot League is wary about the sustainability of this current model.

Completely understand the competitive approach is not for every community. The non-competitive “Fountains” coming with GYSR v2 will provide a friendly alternative.

On the flip side, there are many pros to the “gamified” staking mechanics, such as increasing engagement and participation. It tends to appeal to more of the “power-user” persona.

It’s also worth noting that the Ampleforth contract is also competitive. It obviously does not include a GYSR spending multiplier, but the time bonus does pull from the larger pool in the same way.

And on the point of taking advantage of the GYSR multiplier, the v1 mechanics utilize a logarithmic curve to reduce the impact of big spenders. In v2, we are actually rolling out more efficiency improvements to improve “fairness” (though this is generally a hard question)

@felix

I also think that we shouldn’t use Gysr to a large extent due to the received by owning $GYSR next to some of the other concerns mentioned.

Just to clarify, there’s no additional reward for just “holding” GYSR token. It actually gets spent and becomes an income stream for the Geyser creator (which would be the pilot league multisig in this case)