[GRANT] Add Idle as a yield source on pooltogether
Abstract
PoolTogether is a decentralized protocol for no-loss prize games on the Ethereum blockchain. Prize games are pools of funds whose accrued interest from the yield source is distributed as prizes. Pooltogether allows adding custom yield sources. This proposal is to add idle pools as a yield source.
Scope of the Work
The work involves writing contracts to add idle as a yield source and testing integration with pooltogether contracts.
Current WIP repo: GitHub - 0xrs/idle-pooltogether
Hi @gggggg welcome to the forum,
didnāt know that you were 0xrs, so congrats for winning the tranches Gitcoin Bounty!
Itās great to see that you picked up @unicorn idea!
One thing that I see in the code is that you are using tokenPrice directly while instead,
you should consider the fee also (both when redeeming and when calculating balanceOfToken).
You should check this out tokenPrice - Idle specifically the NOTE section.
One minor thing also that should be added is a method for transferring out governance tokens (COMP, IDLE) that will be awarded to the pool itself, I will ask more info to the Pooltogether team / invite them in our Discord.
I know that also @sunnyRK (EDIT: Welcome to the forum!), another gitcoin bounty winner for the on-top strategies bounty, was looking at this bounty you may be working together (you guys both used tokenPrice and both not handled got tokens initially ). I know that the code to develop is not a lot but maybe one can do the code and one the tests? just throwing some ideas
For the budget I think itās a bit too high for this implementation given the limited scope compared to the Gitcoin bounties, where more complex strategies were required, and also given the different market conditions for IDLE. I think a 200-250 IDLE bounty would be more aligned, but Iām open to hear other voices
Hey, itās okay if I donāt win.
I am doing for learning purpose and would be cool to help even for a small rewardā¦
I will post my code soon here:)
Hey @william, Thanks a ton for reviewing the code and pointing those out (I was planning to handle both the issues after setting up basic test flow). Also thanks for awarding me the bounty for tranches issue. Iām really grateful. Regarding the bounty amount I think youāre right this one has a smaller scope so 200-250 IDLE seems fair. @sunnyRK Hey sorry I wasnāt aware that you were also working on it. Iām open to creating a team or if you want to pick this one up thatās also perfectly fine with me (looking at the size of this issue, itās probably not worth the hassle of coordination). I can focus on some other ideas for idle Iāve been toying around with and work on those. Just sharing this in case you havenāt seen this implementation (GitHub - steffenix/sushi-pooltogether) to use as a reference.
Open to hearing any other thoughts.
Thanks
Hey all! Super excited to see this is being worked on! PoolTogether Inc would be happy to match the bounty being provided by IDLE assuming an integration can be built up to our minimum standards. A few notes from our side:
Great to see that we can move on with this innovative integration! Very excited to see this come to life soon
In order to spin-off the process, we officially launch this grant formulated here from @gggggg.
Since @gggggg already used the Idle template for grants we can now confirm that this is an officially approved grant, confirming the allocation of the Budget of 250 $IDLE + matching grant by pooltogether by the Pilot League Committee.
I have made changes in the smart contract as @william suggest to me on DM
and also @Brendan from pooltogether suggests on DM very good instructions for the mock test, Fork script, and code coverage badgeā¦
both suggestions are doneā¦
let me know if changes neededā¦
Plz have a look if you get time:)
Thanks for the work so far. I reviewed the code and sent some minor comments on Discord, but looks good to me for the Idle side! @lay2000lbs and @Brendan let us know if all the guidelins have been followed and in if we can officialy close the grant.
Looping back on this, we are going to include the IDLE integration in our upcoming audit (scheduled to be competed in June). Once this is done it means:
Anyone can create a prize pool for any asset IDLE supports
We can submit a specific prize pool to POOL governance to be incentived with POOL token distribution
The Treasury League & Dev League have finalized the review of the work delivered by @sunnyRK. We, therefore, proceed now with the payment of 250 $IDLE, which is going to be paid in the following days . Update on the payment transaction will follow.
Thanks to @sunnyRK for the great work and the outcome for the Idle community .
). I know that the code to develop is not a lot but maybe one can do the code and one the tests? just throwing some ideas
. Update on the payment transaction will follow.
.