Hi @gggggg welcome to the forum,
didn’t know that you were 0xrs, so congrats for winning the tranches Gitcoin Bounty!
It’s great to see that you picked up @unicorn idea!
One thing that I see in the code is that you are using
tokenPrice directly while instead,
you should consider the fee also (both when redeeming and when calculating
You should check this out tokenPrice - Idle specifically the
One minor thing also that should be added is a method for transferring out governance tokens (COMP, IDLE) that will be awarded to the pool itself, I will ask more info to the Pooltogether team / invite them in our Discord.
I know that also @sunnyRK (EDIT: Welcome to the forum!), another gitcoin bounty winner for the on-top strategies bounty, was looking at this bounty you may be working together (you guys both used
tokenPrice and both not handled got tokens initially ). I know that the code to develop is not a lot but maybe one can do the code and one the tests? just throwing some ideas
For the budget I think it’s a bit too high for this implementation given the limited scope compared to the Gitcoin bounties, where more complex strategies were required, and also given the different market conditions for IDLE. I think a 200-250 IDLE bounty would be more aligned, but I’m open to hear other voices