[GRANT] Add Idle as a yield source on pooltogether

[GRANT] Add Idle as a yield source on pooltogether

Abstract

PoolTogether is a decentralized protocol for no-loss prize games on the Ethereum blockchain. Prize games are pools of funds whose accrued interest from the yield source is distributed as prizes. Pooltogether allows adding custom yield sources. This proposal is to add idle pools as a yield source.

Scope of the Work

The work involves writing contracts to add idle as a yield source and testing integration with pooltogether contracts.
Current WIP repo: GitHub - 0xrs/idle-pooltogether

Discussion Links

The idea was proposed by @unicorn on discord here
Pooltogether: Website and Docs

Budget

250 $IDLE + matching grant by pooltogether [edited]

Team

@sunnyRK and @gggggg (both have contributed to idle before through gitcoin grants)

Timeline

Hard deadline for final delivery is 30th April (factoring in time for testing + review)

11 Likes

Hey Great work I am also developed a smart contract.
working on testcase side.

5 Likes

Hi @gggggg welcome to the forum,
didn’t know that you were 0xrs, so congrats for winning the tranches Gitcoin Bounty!

It’s great to see that you picked up @unicorn idea!

One thing that I see in the code is that you are using tokenPrice directly while instead,
you should consider the fee also (both when redeeming and when calculating balanceOfToken).
You should check this out tokenPrice - Idle specifically the NOTE section.
One minor thing also that should be added is a method for transferring out governance tokens (COMP, IDLE) that will be awarded to the pool itself, I will ask more info to the Pooltogether team / invite them in our Discord.

I know that also @sunnyRK (EDIT: Welcome to the forum!), another gitcoin bounty winner for the on-top strategies bounty, was looking at this bounty you may be working together (you guys both used tokenPrice and both not handled got tokens initially :slight_smile: ). I know that the code to develop is not a lot but maybe one can do the code and one the tests? just throwing some ideas

For the budget I think it’s a bit too high for this implementation given the limited scope compared to the Gitcoin bounties, where more complex strategies were required, and also given the different market conditions for IDLE. I think a 200-250 IDLE bounty would be more aligned, but I’m open to hear other voices

6 Likes

Hey, it’s okay if I don’t win.
I am doing for learning purpose and would be cool to help even for a small reward…
I will post my code soon here:)

7 Likes

Hey @william, Thanks a ton for reviewing the code and pointing those out (I was planning to handle both the issues after setting up basic test flow). Also thanks for awarding me the bounty for tranches issue. I’m really grateful. Regarding the bounty amount I think you’re right this one has a smaller scope so 200-250 IDLE seems fair.
@sunnyRK Hey sorry I wasn’t aware that you were also working on it. I’m open to creating a team or if you want to pick this one up that’s also perfectly fine with me (looking at the size of this issue, it’s probably not worth the hassle of coordination). I can focus on some other ideas for idle I’ve been toying around with and work on those. Just sharing this in case you haven’t seen this implementation (GitHub - steffenix/sushi-pooltogether) to use as a reference.
Open to hearing any other thoughts.
Thanks

6 Likes

Hey all! Super excited to see this is being worked on! PoolTogether Inc would be happy to match the bounty being provided by IDLE assuming an integration can be built up to our minimum standards. A few notes from our side:

Let us know any questions! Excited to have this done!!

11 Likes

hi @gggggg and @sunnyRK I am really happy to see you guys getting excited and building cool stuff for Idle :rocket:

Idle will always be the best as long as we can keep talented members on-board!

I will ask @william to transfer my 25 $IDLE to @sunnyRK and I will DM @gggggg to add 25 $IDLE out of my pocket.

Thanks @lay2000lbs for supporting… This is the best of blockchains.
:pray:

7 Likes

I’m pumped to see such a supportive community and the integration soon live, thanks @lay2000lbs and @unicorn ! :grin:

6 Likes

Great to see that we can move on with this innovative integration! Very excited to see this come to life soon :rocket:

In order to spin-off the process, we officially launch this grant formulated here from @gggggg.
Since @gggggg already used the Idle template for grants we can now confirm that this is an officially approved grant, confirming the allocation of the Budget of 250 $IDLE + matching grant by pooltogether by the Pilot League Committee.

9 Likes

Awesome idea! Looking forward to seeing it implemented. I’ll def pool my IDLEs

4 Likes

Hey Team,

I have made changes in the smart contract as @william suggest to me on DM
and also @Brendan from pooltogether suggests on DM very good instructions for the mock test, Fork script, and code coverage badge…
both suggestions are done…
let me know if changes needed…
Plz have a look if you get time:)

8 Likes

Thanks for the work so far. I reviewed the code and sent some minor comments on Discord, but looks good to me for the Idle side!
@lay2000lbs and @Brendan let us know if all the guidelins have been followed and in if we can officialy close the grant.

6 Likes

Looping back on this, we are going to include the IDLE integration in our upcoming audit (scheduled to be competed in June). Once this is done it means:

  1. Anyone can create a prize pool for any asset IDLE supports
  2. We can submit a specific prize pool to POOL governance to be incentived with POOL token distribution
7 Likes

The Treasury League & Dev League have finalized the review of the work delivered by @sunnyRK. We, therefore, proceed now with the payment of 250 $IDLE, which is going to be paid in the following days :money_with_wings:. Update on the payment transaction will follow.

Thanks to @sunnyRK for the great work and the outcome for the Idle community :family_man_woman_girl_boy: :heart:.

7 Likes

The payment is processed, see details for verification below:

  • 250 IDLE to 0x176c5Ef0FDf36736F9F1F1AC9376D6Dbb893cA14
    Hash : 0xfbd09ff64f3350e042a9080d86a71d0e15e54b40c2d38db0ffa30880131e7c7f

Thanks again for your work @sunnyRK :clap:

CC: @lay2000lbs

7 Likes

Hey @Salome ,
Thank you, I got the 250 IDLE Payment!!

7 Likes

Since the Polygon integration is around the corner - can we use this strategy in a similar way on Polygyon since PT can be used as a source there?

2 Likes