Peer Review
Hi All,
The snapshot vote for an audit vs peer review has closed with peer review having ~72% of the vote. Snapshot vote
With the vote out of the way, I would now like to invite members from the community to review the github repo [[ here ]].
The code has been internally reviewed by @gravityblast and @william .
As a high level overview to reviewers, there are two contracts which have been developed for the smart treasury
- Bootstrap contract -
SmartTreasuryBootstrap.sol
- FeeCollector contract -
FeeCollector.sol
The purpose of the boostrap contract is to correctly configure the smart treasury with the parameters agreed upon by governance, and to deposit the correct amount of IDLE and WETH into the initial pool.
The purpose of the fee collector is to route fees which are generated by the IDLE protocol into WETH and send it to the smart treasury, and the fee treasury based on an allocation parameter. In the future, more accounts can be added to this list (such as the community treasury etc).
The initial configuration of the smart treasury is probably the most technical part of the contract, and the deployment is summarised here. Post reference: Progress Update 1
Once the smart treasury is created, the address must be set in the fee collector. After which
More details on the proposal spec can be found here Progress Update 2
The repo has unit tests and integration tests which are located under the tests/
directory. The steps to replicate the full end-end proposal process is under migrations/
In order to run the tests, a local ganache main-net fork may need to be run with further instructions on the README.
The peer-review will close on 2021-01-24T00:00:00Z. After which (If there are no outstanding issues) I will proceed with the IIP.
@emilianobonassi @endymionjkb @Fernando @MickdeGraaf
Thanks,
Asaf